This repository was archived by the owner on Oct 31, 2024. It is now read-only.
support run spoke agent outside of managed cluster#175
Merged
openshift-merge-robot merged 2 commits intoopen-cluster-management-io:mainfrom Dec 8, 2021
Merged
support run spoke agent outside of managed cluster#175openshift-merge-robot merged 2 commits intoopen-cluster-management-io:mainfrom
openshift-merge-robot merged 2 commits intoopen-cluster-management-io:mainfrom
Conversation
zhujian7
force-pushed
the
agent-outside
branch
4 times, most recently
from
20c834c to
3c202a0
Compare
zhujian7
force-pushed
the
agent-outside
branch
from
3c202a0 to
56660ff
Compare
zhujian7
force-pushed
the
agent-outside
branch
from
56660ff to
e8551a9
Compare
zhujian7
changed the title
zhujian7
force-pushed
the
agent-outside
branch
from
e8551a9 to
572e2f8
Compare
qiujian16
reviewed
Dec 6, 2021
| o.ClusterName, o.AgentName, o.ComponentNamespace, o.HubKubeconfigSecret, | ||
| kubeconfigData, | ||
| spokeKubeClient.CoreV1(), | ||
| // store the secret in the cluster where the agent pod runs |
Member
There was a problem hiding this comment.
I think we should add some more comment here. Maybe also a TODO to revisit whether we should put secret for addon on agent cluster or spoke cluster.
qiujian16
reviewed
Dec 6, 2021
Member
qiujian16
left a comment
qiujian16
left a comment
There was a problem hiding this comment.
I think we should save the secret on spoke cluster for now instead of agent cluster. It can at least ensure that addon can still work today.
zhujian7
force-pushed
the
agent-outside
branch
3 times, most recently
from
db0fb42 to
1ae7b80
Compare
qiujian16
reviewed
Dec 7, 2021
Signed-off-by: zhujian <jiazhu@redhat.com>
zhujian7
force-pushed
the
agent-outside
branch
from
1ae7b80 to
23bbde3
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/assign @skeeey |
skeeey
reviewed
Dec 8, 2021
skeeey
reviewed
Dec 8, 2021
Signed-off-by: zhujian <jiazhu@redhat.com>
zhujian7
force-pushed
the
agent-outside
branch
from
865a3f5 to
65122b6
Compare
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhujian jiazhu@redhat.com
The
registration-agentpod can be deployed on a separate cluster from the managed cluster, and thehub-kubeconfig-secretwill be stored in the cluster where theregistration-agentpod resides.related issue: open-cluster-management-io/registration-operator#158
todo:
cc @xuezhaojun @qiujian16